Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voluntary exit #1200

Merged
merged 70 commits into from
Dec 11, 2023
Merged

Voluntary exit #1200

merged 70 commits into from
Dec 11, 2023

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Nov 9, 2023 •
edited
Loading

  • Add what's missing in the new runner structure for voluntary exit
  • Update the BeaconNode with the VoluntaryExit calls and create a new duty handler for the voluntary exit duty
  • Trigger exit upon exit event from the contract
  • Voluntary Exit rules for msg validation
  • Trigger exit upon exit event from the contract test

@nkryuchkov nkryuchkov changed the title Trigger voluntary exit duty Voluntary exit Nov 9, 2023
y0sher
y0sher reviewed Nov 9, 2023
View reviewed changes
eth/eventhandler/handlers.go Outdated Show resolved Hide resolved
@nkryuchkov
Cleanup [2]
2f78a8b
@nkryuchkov
Call SubmitVoluntaryExit in beacon client
b88f911
@nkryuchkov
Merge branch 'stage' into voluntary-exit
c24150e
@nkryuchkov
Remove unused argument from SubmitVoluntaryExit
0dd8c0d
@nkryuchkov
Deploy to 17-20
d6d3d00
@nkryuchkov
Add message validation rules for voluntary exit
4f059c3
@nkryuchkov
Add ValidatorExited event support to local events
5c4a5bc
@nkryuchkov
Merge branch 'stage' into voluntary-exit
fe55119
@nkryuchkov
Add ValidatorExited to events example
7e53e26
@nkryuchkov
Apply contract changes from ssvlabs/ssv-network#278
c8cfa85
@nkryuchkov
Revert "Deploy to 17-20"
f0691cf 
This reverts commit d6d3d00.
@nkryuchkov
Remove GetDefaultDomain from EventHandler
c99fd8f
@nkryuchkov
Update simcontract
39b66aa
@nkryuchkov
Remove a TODO
7b6ee0b
@nkryuchkov
Add TestValidatorExitedEventsInput
54d6075
@nkryuchkov
Add voluntary exit log
759d4a5
@nkryuchkov
Revert "Add TestValidatorExitedEventsInput"
5cac687 
This reverts commit 54d6075.
@nkryuchkov
Revert "Update simcontract"
3b5c1bc 
This reverts commit 39b66aa.
@nkryuchkov
Deploy to 1-4
22792b1
@nkryuchkov
Improve logging
d4e0e14
@nkryuchkov
More logging
4c4b5a6
@nkryuchkov
Fix logs
5f17070
@nkryuchkov
Fix empty pubkey
52ea008
@nkryuchkov
Cleanup logging
05245d9
@nkryuchkov
Add voluntary exit where it's missing
814d7fd
MatusKysel
MatusKysel previously approved these changes Nov 30, 2023
View reviewed changes
@MatheusFranco99 MatheusFranco99 dismissed stale reviews from MatusKysel and moshe-blox via 9fa77f5 December 3, 2023 15:10
MatusKysel
MatusKysel previously approved these changes Dec 6, 2023
View reviewed changes
@y0sher y0sher requested a review from olegshmuelov December 7, 2023 13:31
@y0sher
Copy link
Contributor

y0sher commented Dec 7, 2023

Since @olegshmuelov is back and this touches some of his areas I would love him to review it as well. approved on my end though.

moshe-blox
moshe-blox previously approved these changes Dec 10, 2023
View reviewed changes
olegshmuelov
olegshmuelov requested changes Dec 10, 2023
View reviewed changes
operator/duties/voluntary_exit.go Outdated Show resolved Hide resolved
@y0sher y0sher requested review from olegshmuelov and removed request for liorrutenberg and olegshmuelov December 10, 2023 15:14
@moshe-blox moshe-blox merged commit fb113d9 into stage Dec 11, 2023
5 checks passed
@moshe-blox moshe-blox deleted the voluntary-exit branch December 11, 2023 15:52
moshe-blox added a commit that referenced this pull request Jan 2, 2024
@y0sher @moshe-blox
@MatusKysel @nkryuchkov @olegshmuelov @MatheusFranco99 @AKorpusenko @GalRogozinski @pavelkrolevets
v1.2.2 (#1248)
ff2f594 
* fix: stale operator ID in `p2pNetwork` (#1229)

* fix: stale operator ID in `p2pNetwork`

---------

Co-authored-by: Lior Rutenberg <liorr@blox.io>

* fix: sufficient timeout for initial duty fetch (#1214)

* fix: sufficient timeout for initial duty fetch (#1214)
---------

Co-authored-by: Matus Kysel <matus@blox.io>

* deployment: change bootnode for holesky-stage (#1233)

* deploy new bootnode ENR for holesky stage

* Voluntary exit (#1200)

* Voluntary exit

---------

Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: olegshmuelov <oleg@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>

* feat: include 'connected' in peer scores log (#1224)

* feat: include 'connected' in peer scores log

* P2P metrics  (#1163)

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* review comments fixes

* deploy

* deploy

* testing metrics differ

* added duties created and finalized

* removed extra monitoring.metricsreporter usage

* removed topic from p4score. made it a sum of squares

* deploy to all nodes

* deploy p2p_metrics

* pr review fixes

* trigger ci

* deploy 9-20

* Fix msg validation rsa verification counter metric

* allocate p2p_metrics

* inspect scores more frequently, but don't log every time

* renamed duties created/finalized metrics and refactored to record role

* deploy to 5--8

* deploy to 5--8

* rename metric

* blank space

* approve spec change (just a metric)

* refactors

* reset scores

* metric help msg

* revert gitlab

* deploy

* revert deploy

* Add metrics for signature verifications

* Update differ.config.yaml with approved changes

---------

Co-authored-by: Anton Korpusenko <anton@blox.io>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>
Co-authored-by: moshe-blox <moshe@blox.io>

* Node health (#1203)

* chore: link to SSV API docs in configs & README

* initial commit

* add node health route to ssv API

* update health route

* update health route

* update health route

* update health route

* deploy to stage

* add plaintext response

* lint

* lint

* change to good/bad

* lint

* lint

* refactor

* Revert "deploy to stage"

This reverts commit 2f54f4e.

* lint

* add inbound/outbound count for health + deploy to stage

* change ports back

* update count

* lint

* update conns

* lint

* remove connected peer count

* test blocked ports

* Revert "remove connected peer count"

This reverts commit 79e2b94.

* leave only active peers count

* Revert "test blocked ports"

This reverts commit 6fc9282.

* ci to stage

* add mutex to nodes access

* refactor: node health API (#1222)

* refactor: node health API

* added cpu_cores to healthcheck output

* fix inbound/outbound stats

* Remove CPU core reporting

---------

Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com>

* feat: subscribe to a random subnet with 0 validators (#1245)

* feat: subscribe to a random subnet with 0 validators

* Fix: health route host addres (#1246)

* node health api route advertises the host addresses from the config.

* set up listenaddress directly

* feat: rate limit inbound connections by IP (#1226)

* feat: rate limit inbound connections by IP

* activate conngater

* deploy to 5--8

* fix

* fix

* Refactor connection gating in p2p setup

* Update ipLimiter parameters

* revert gitlab

* Revert "revert gitlab"

This reverts commit fcc7902.

* Revert "Revert "revert gitlab""

This reverts commit feb9e4e.

---------

Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>

---------

Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com>
Co-authored-by: Lior Rutenberg <liorr@blox.io>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com>
Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: olegshmuelov <oleg@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>
Co-authored-by: Anton Korpusenko <antokorp@gmail.com>
Co-authored-by: Anton Korpusenko <anton@blox.io>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
Co-authored-by: Pavel Krolevets <pavelkrolevets@gmail.com>
y0sher added a commit that referenced this pull request Jul 28, 2024
@linghuying @moshe-blox
@y0sher @MatusKysel @nkryuchkov @olegshmuelov @MatheusFranco99 @AKorpusenko @GalRogozinski @pavelkrolevets
chore: fix some function names (#1413)
9726dce 
* fix: stale operator ID in `p2pNetwork` (#1229) (#1230)

* fix: stale operator ID in `p2pNetwork`

---------

Co-authored-by: Lior Rutenberg <liorr@blox.io>

* v1.2.2 (#1248)

* fix: stale operator ID in `p2pNetwork` (#1229)

* fix: stale operator ID in `p2pNetwork`

---------

Co-authored-by: Lior Rutenberg <liorr@blox.io>

* fix: sufficient timeout for initial duty fetch (#1214)

* fix: sufficient timeout for initial duty fetch (#1214)
---------

Co-authored-by: Matus Kysel <matus@blox.io>

* deployment: change bootnode for holesky-stage (#1233)

* deploy new bootnode ENR for holesky stage

* Voluntary exit (#1200)

* Voluntary exit

---------

Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: olegshmuelov <oleg@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>

* feat: include 'connected' in peer scores log (#1224)

* feat: include 'connected' in peer scores log

* P2P metrics  (#1163)

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* review comments fixes

* deploy

* deploy

* testing metrics differ

* added duties created and finalized

* removed extra monitoring.metricsreporter usage

* removed topic from p4score. made it a sum of squares

* deploy to all nodes

* deploy p2p_metrics

* pr review fixes

* trigger ci

* deploy 9-20

* Fix msg validation rsa verification counter metric

* allocate p2p_metrics

* inspect scores more frequently, but don't log every time

* renamed duties created/finalized metrics and refactored to record role

* deploy to 5--8

* deploy to 5--8

* rename metric

* blank space

* approve spec change (just a metric)

* refactors

* reset scores

* metric help msg

* revert gitlab

* deploy

* revert deploy

* Add metrics for signature verifications

* Update differ.config.yaml with approved changes

---------

Co-authored-by: Anton Korpusenko <anton@blox.io>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>
Co-authored-by: moshe-blox <moshe@blox.io>

* Node health (#1203)

* chore: link to SSV API docs in configs & README

* initial commit

* add node health route to ssv API

* update health route

* update health route

* update health route

* update health route

* deploy to stage

* add plaintext response

* lint

* lint

* change to good/bad

* lint

* lint

* refactor

* Revert "deploy to stage"

This reverts commit 2f54f4e.

* lint

* add inbound/outbound count for health + deploy to stage

* change ports back

* update count

* lint

* update conns

* lint

* remove connected peer count

* test blocked ports

* Revert "remove connected peer count"

This reverts commit 79e2b94.

* leave only active peers count

* Revert "test blocked ports"

This reverts commit 6fc9282.

* ci to stage

* add mutex to nodes access

* refactor: node health API (#1222)

* refactor: node health API

* added cpu_cores to healthcheck output

* fix inbound/outbound stats

* Remove CPU core reporting

---------

Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com>

* feat: subscribe to a random subnet with 0 validators (#1245)

* feat: subscribe to a random subnet with 0 validators

* Fix: health route host addres (#1246)

* node health api route advertises the host addresses from the config.

* set up listenaddress directly

* feat: rate limit inbound connections by IP (#1226)

* feat: rate limit inbound connections by IP

* activate conngater

* deploy to 5--8

* fix

* fix

* Refactor connection gating in p2p setup

* Update ipLimiter parameters

* revert gitlab

* Revert "revert gitlab"

This reverts commit fcc7902.

* Revert "Revert "revert gitlab""

This reverts commit feb9e4e.

---------

Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>

---------

Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com>
Co-authored-by: Lior Rutenberg <liorr@blox.io>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com>
Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: olegshmuelov <oleg@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>
Co-authored-by: Anton Korpusenko <antokorp@gmail.com>
Co-authored-by: Anton Korpusenko <anton@blox.io>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
Co-authored-by: Pavel Krolevets <pavelkrolevets@gmail.com>

* Revert "v1.2.2 (#1248)" (#1263)

This reverts commit ff2f594.

* chore: fix some function names

Signed-off-by: linghuying <1599935829@qq.com>

---------

Signed-off-by: linghuying <1599935829@qq.com>
Co-authored-by: Lior Rutenberg <liorr@blox.io>
Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com>
Co-authored-by: rehs0y <lyosher@gmail.com>
Co-authored-by: Matus Kysel <matus@blox.io>
Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com>
Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: olegshmuelov <oleg@blox.io>
Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>
Co-authored-by: Anton Korpusenko <antokorp@gmail.com>
Co-authored-by: Anton Korpusenko <anton@blox.io>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
Co-authored-by: Pavel Krolevets <pavelkrolevets@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0sher y0sher y0sher approved these changes

@olegshmuelov olegshmuelov olegshmuelov approved these changes

@moshe-blox moshe-blox moshe-blox approved these changes

@MatusKysel MatusKysel MatusKysel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nkryuchkov @moshe-blox @y0sher @MatusKysel @olegshmuelov @MatheusFranco99