Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] open a note for review can not open notes correctly. #328

Closed
11-check-it-out opened this issue Nov 30, 2021 · 2 comments · Fixed by #1088
Closed

[BUG] open a note for review can not open notes correctly. #328

11-check-it-out opened this issue Nov 30, 2021 · 2 comments · Fixed by #1088
Labels
bug Something isn't working

Comments

@11-check-it-out
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Click open a note for review in state bar.
  2. The plugin opens the notes that should be reviewed tomorrow.

Expected behavior
Because there is no note that should be reviewd today, so the plugin should open a note in New queue.

Screenshots

2021-11-30.15-07-40.mp4

Versions (please complete the following information):

  • OS: win11 insider preview build 22504
  • Obsidian version: v0.13.6
  • Plugin version: v1.6.2
  • If on desktop, Installer version: "5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/0.12.5 Chrome/89.0.4389.128 Electron/12.0.11 Safari/537.36"

Additional context
No
@11-check-it-out 11-check-it-out added the bug Something isn't working label Nov 30, 2021
@11-check-it-out
Copy link
Contributor Author

11-check-it-out commented Dec 8, 2021 •
edited
Loading

Now the number of review note is completely wrong. However I maybe know the reason. Once the review data of a note was modified accidently, and then the plugin became weird. Is there any resolution, or just delete all review data?

@11-check-it-out
Copy link
Contributor Author

11-check-it-out commented Mar 24, 2022 •
edited
Loading

The issue has come up again. Yesterday I used the plugin to review notes and three notes were marked with invalid yaml. Then today that function is not working again. But other functions are still normal.

%ZWIEOV$3WXY(SOVY)AIDFP

Last time I solved it by uninstalling and reinstalling the plugin, this time that method failed.

@github-actions github-actions bot added the stale label Apr 9, 2023
@st3v3nmw st3v3nmw removed the stale label May 13, 2023
@ronzulu ronzulu mentioned this issue Mar 19, 2024
Closed
@ronzulu ronzulu mentioned this issue May 5, 2024
Open
carlosgaldino added a commit to carlosgaldino/obsidian-spaced-repetition that referenced this issue Sep 23, 2024
@carlosgaldino
Review only due notes
d3d7f98 
This patch fixes the behaviour of determining the next note to only
consider notes that are due. If a note is scheduled in the future, it
won't be picked up for review until it's due.

This is the same patch as st3v3nmw#947.

Fixes st3v3nmw#328.
carlosgaldino added a commit to carlosgaldino/obsidian-spaced-repetition that referenced this issue Sep 23, 2024
@carlosgaldino
Review only due notes
8bd7046 
This patch fixes the behaviour of determining the next note to only
consider notes that are due. If a note is scheduled in the future, it
won't be picked up for review until it's due.

This is the same patch as st3v3nmw#947.

Fixes st3v3nmw#328.
@carlosgaldino carlosgaldino mentioned this issue Sep 23, 2024
Merged
carlosgaldino added a commit to carlosgaldino/obsidian-spaced-repetition that referenced this issue Sep 23, 2024
@carlosgaldino
fix: Review only due notes
2ef3800 
This patch fixes the behaviour of determining the next note to only
consider notes that are due. If a note is scheduled in the future, it
won't be picked up for review until it's due.

This is the same patch as st3v3nmw#947.

Fixes st3v3nmw#328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Review only due notes carlosgaldino/obsidian-spaced-repetition
2 participants
@st3v3nmw @11-check-it-out