-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Support Please #335
Comments
Hey. This will be awesome! Cannot use the plugin for my native language right now :( |
Shalom and/or salam @danzilberdan Just to get some background, I translated a recent comment I posted using google translate: However, when I pasted it into Obsidian the RTL didn't match: Then when I changed the Obsidian editor setting for RTL it did display correctly: Can we assume that this fix only needs to work Obsidian itself is set for RTL? Are you using the
Cheers |
Understood. When changing Obsidian's default direction to RTL it works. But it is not useful because I type most of my notes LTR and just some in RTL. I am using Obsidian RTL Plugin and using the frontmatter as you have written. |
I've made a simple change (using the HTML I've changed yesterday's text to be a question (with Obsidian RTL on):: The flashcard (I think) displays correctly with this test code (Obsidian RTL off): Note that I haven't installed the TestingCould you please try out this test version of plug-in. You will need to copy that to the obsidian plug-in folder, e.g. Then reload the plug-in, or restart obsidian. Note that the display of flashcards is currently hard coded for RTL (i.e. doesn't check the direction frontmatter) |
Perfect! And event better if it would parse the frontmatter. Amazing! |
Great that it worked. I've now added the frontmatter check so hopefully this is complete now. I've also updated the flashcard "quick edit" modal to also honor the frontmatter direction setting, so if you could please verify that that works as well. If all ok, then I'll create the PR so that it can be merged into the next mainstream release. Cheers |
I've noticed that you contributed the Arabic translation to this plug-in and thought you might be interested in the requested RTL functionality that I've implemented. It's in beta testing at the moment, and was wondering if you would be able to test as well. The latest code is the This new feature is probably only relevant if you have both LTR and RTL flashcards within the one vault, and use the Any feedback appreciated. Cheers |
This has been released into the latest mainstream release 1.12.5 |
Is your feature request related to a problem? Please describe.
I use rtl plugin for some language written from right to left.. it works for editor and preview mode, but not flashcard mode..
Editor Mode :
Preview / Reading Mode :
Flashcard Mode :
Describe the solution you'd like
Flashcard should be display something like Preview / Reading Mode.
the solution can be something to detect if display are using RTL or not (based on frontmatters showed in editor mode above ) :
if yes, then display flashcard with RTL mode activated
The text was updated successfully, but these errors were encountered: