Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Problem with nested list item's indentation #800

Closed
atipugin opened this issue Nov 24, 2023 · 7 comments
Closed

[BUG] Problem with nested list item's indentation #800

atipugin opened this issue Nov 24, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@atipugin
Copy link

Describe the bug
Indentation level gets lost after review in case if card is nested inside a list. E.g.:

- foo
    - bar?::baz

transforms into:

- foo
- bar?::baz <!--SR:!2023-11-25,1,230-->

To Reproduce
Steps to reproduce the behavior:

  1. Create a card nested inside a list.
  2. Review the card.

Expected behavior

Plugin shouldn't change item's indentaton and only append comment with metadata.

- foo
    - bar?::baz <!--SR:!2023-11-25,1,230-->

Screenshots

None.

Versions (please complete the following information):

  • OS: macOS 14.0
  • Obsidian version: 1.4.16
  • Plugin version: 1.10.5
  • If on desktop, Installer version: 1.4.13

Additional context

None.

@atipugin atipugin added the bug Something isn't working label Nov 24, 2023
@jajaperson
Copy link

jajaperson commented Nov 29, 2023

Getting this on iOS too, only began recently though.

@ronzulu
Copy link
Collaborator

ronzulu commented Nov 29, 2023

Sorry, that could have been my doing when making the code tolerant of leading/trailing spaces.

I'll have a look, hopefully today.

Cheers
Ronny

@ronzulu
Copy link
Collaborator

ronzulu commented Dec 11, 2023

Hi @atipugin & @jajaperson

Sorry about the delay, here is an update ready for beta testing.

There is a file called main.js in this zip file
main_800A.zip

You will need to copy that to the obsidian plug-in folder, e.g.
D:\Obsidian\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in. Please let me know how it goes.

Ronny

@ronzulu
Copy link
Collaborator

ronzulu commented Dec 19, 2023

Hi @atipugin & @jajaperson

Did you get a chance to check the version from my previous post? If ok, I'll put in the merge request.

@atipugin
Copy link
Author

atipugin commented Dec 19, 2023

Hey @ronzul,

Looks like the issue is gone! 🙏
image

@ronzulu
Copy link
Collaborator

ronzulu commented Jan 10, 2024

Hi @atipugin the fix has been included in the latest release 1.11.0. Please close this at your convenience.

Cheers
Ronny

@atipugin
Copy link
Author

@ronzulu great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants