Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support richer set of flashcard ordering during review; e.g. random card from random deck #814

Closed
ronzulu opened this issue Dec 14, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@ronzulu
Copy link
Collaborator

ronzulu commented Dec 14, 2023

Current Functionality

At present the plug-in has two methods of ordering flashcards during review. These are based on the setting:
image

Where this option enables randomization within a single deck.


Solution Implemented

I have implemented greater flexibility with the following options:
image

image


Feedback wanted

This enhancement was beta tested successfully for #610.

However I would appreciate wider feedback from anyone before opening a PR.

@ronzulu ronzulu added the enhancement New feature or request label Dec 14, 2023
@ronzulu
Copy link
Collaborator Author

ronzulu commented Jan 10, 2024

Hi @st3v3nmw thanks for including this on the latest release.

@ronzulu ronzulu closed this as completed Jan 10, 2024
@4Source
Copy link
Contributor

4Source commented Jan 20, 2024

Random card from random deck breaks the heading. Normally you would get as heading the name of the deck you clicked with this option you get the sub deck it choose randomly in the deck you clicked.

@ronzulu
Copy link
Collaborator Author

ronzulu commented Jan 21, 2024

Hi @4Source thanks for the prompt, it wasn't something I was particularly happy with.

For "Random card from random deck" ordering, what do you think of:
${deckName} (and ${subdeckCount} subdecks): ${cardCount}`

Where:
deckName - the name of the deck chosen by the user (doesn't change as cards from different subdecks are shown)
subdeckCount - count of subdecks under the deck chosen by the user. I'm leaning towards this being the remaining count, i.e. the count of subdecks that have remaining cards for review
cardCount - total number of cards remaining (I.e. not the count of cards remaining in the current randomly chosen deck).

Let me know what you think.

Cheers
Ronny

@4Source
Copy link
Contributor

4Source commented Jan 21, 2024

Sounds good, but subdeckCount counts only the top level of subdecks or count it each subdeck at each level below?

Maybe change the Format to:
${deckName}: ${cardCount}
and a subtitle:
Subdecks: ${subdeckCount}

Other option:
${deckName}: ${cardCount}
and a subtitle:
${subdeckName}: ${subdeckCardCount}

@ronzulu
Copy link
Collaborator Author

ronzulu commented Jan 21, 2024

Sounds good, but subdeckCount counts only the top level of subdecks or count it each subdeck at each level below?

Maybe change the Format to: ${deckName}: ${cardCount} and a subtitle: Subdecks: ${subdeckCount}

I was thinking that the ${subdeckCount} would be the total number of descendant decks. That way a person would see this number decrease every time all cards completed review in any descendant deck and see some progress during the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants