-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] More control over the flashcard ordering #946
Comments
Hi @4Source Wow. Man, you've put in so much work to get to this point. I've only had a chance to look at this briefly, but had a few questions for you. Are the "deck priority" and "card priority" headings crossed over against the column content? I'm wondering if it would be possible to stage the development, rather than adding in everything all in one go. So I'm curious which options are ones that:
@st3v3nmw might think differently, and in the end this is his baby, but I know that for every feature added it requires more than just the implementation time. There is writing the unit test cases, having it reviewed by Stephen or myself et cetera. Hence why I'm wondering if it would be possible to stage the development. Ones that are "nice to have" could be moved to a separate issue, and you could see if people comment and indicate that they would use it if it was implemented. Kudos once again for thinking this all through, it must have taken serious effort! Cheers |
Yeah this took a while. I really thought about this a while (couple of weeks now).
Ohh yes there are switched I will fix this.
Yes I Think this should be possible. And for sure easier to review. A possible Solution could be to firstly ignore the
I'am at the moment not happy with the currently available options and thought I couldn't be the only one who don't would like to have more control how the review presents me the cards. And adding more and more Options to the existing drop down would not be really efficient. And would make a later refactoring harder.
This is one of the reasons why I created this issue, to avoid wasting my time implementing something what don't get included.
Whit the unit test cases I could help and implement them by myself the review part on the other hand I cant really help you only thing I could do add more Comments while going through this. |
This is now a lot more but I added a better description of the configurations and the option for It feels like I am spamming so sry for that.
Development Stage 1The main goal at stage 1 is to prepare the code to accept further modifications. Only implementing the existing functionallity without modifying the unit tests everything should work the same. Development Stage 2Add the function that there is no prioritization of due/new. New unit test are requiered at this stage. Development Stage 3Implements the Round robin option for Card priority. New unit test are requiered at this stage. Development Stage 4Implements the random option for Card priority. New unit test are requiered at this stage. |
Maybe this needs a rethinking here is a order that would be with this setup not possible |
I think that in addition to the above mentioned Card order Also Maybe a solution to reduce the amount of implementations would be if there is no deck order. This would be possible if all Subdecks are combined at the same "level" meaning are contained in the click deck. The Subdeck structure would only be noted for each card, but there is no difference in the order if it was located in a Subdeck or directly in the clicked deck. I think this would also make a lot of sense because if you click on a deck you would like to learn all of the cards inside this deck and if you would like to be more specific "you go a level deeper " and click one of the Subdecks. |
This feature is on top of the #814 should add more control how to go through the cards during review.
I am currently working on it but I would like to here some feedback before continue.
Current Functionality
The new system should consist of 4 drop-down menus which are:
Deck order
In which order the decks get selected.
Card order
In which order the cards in a deck get selected.
Deck priority
How the deck order is prioritized complete the deck or only one card per deck. Could probably extended with a random option.
Card priority
Which cards get prioritized to complete first.
The resulting options are listed here:
&
Sequentially (once all cards in previous deck reviewed)
&
Sequentially (once all cards in previous deck reviewed)
&
Sequentially (once all cards in previous deck reviewed)
&
Sequentially (once all cards in previous deck reviewed)
&
Randomly (once all cards in previous deck reviewed)
&
Randomly (once all cards in previous deck reviewed)
&
Randomly (once all cards in previous deck reviewed)
&
Randomly (once all cards in previous deck reviewed)
&
Every card a random deck with a random card Ignoring new and due
This should nearly address any possible way someone would like to configure the review at least when deck priority includes a random option. And if there are any other needs I think on this base there could be easily added in future.
I would love to hear your thoughts on this, so please share.
The text was updated successfully, but these errors were encountered: