Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embedded notes are displayed twice, since 1.12.5 #1061

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ronzulu
Copy link
Collaborator

@ronzulu ronzulu commented Sep 10, 2024

Fixed #1041

In version 1.12.4 and earlier we used the deprecated Obsidian MarkdownRenderer.renderMarkdown() and we
needed to have our own method "renderTransclude()" that loaded the referenced file and rendered it.

In version 1.12.5, we started using MarkdownRenderer.render() instead, which does this automatically.

@ronzulu ronzulu self-assigned this Sep 10, 2024
@ronzulu ronzulu merged commit 2d2c152 into st3v3nmw:master Sep 10, 2024
1 check passed
st3v3nmw pushed a commit that referenced this pull request Sep 21, 2024
Newdea pushed a commit to open-spaced-repetition/obsidian-spaced-repetition-recall that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Embedded notes are displayed twice starting from version 1.12.5
1 participant