fix: parsing code blocks & custom separators #1081
Merged
+373
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3v3nmw
force-pushed
the
fix-parser
branch
from
a9ec33c
to
5119f6a
Compare
This was referenced Sep 21, 2024
This PR:
1. Adds test cases for parsing {{curly}} clozes
2. Fixes #1072
- Ignore 'cards' in ```block`` & `inline` codeblocks
- Adds test cases for both
3. Fixes #1077
- When all the cloze options aren't being used, `cloze_rules` in
`parser.ts` becomes empty which leads to the empty grammar rule `cloze_text`
which prevents the grammar from being generated. This change adds a
tombstone \0 to address this.
- Adds test cases for this
st3v3nmw
force-pushed
the
fix-parser
branch
2 times, most recently
from
3a74ec9
to
2d70203
Compare
…perly hanlded by clozes - Fixed a new issue related to the case when the user provides empty markers for the inline and multiline cards. With the new version, the rule is disabled when the marker is empty.
st3v3nmw
force-pushed
the
fix-parser
branch
from
2d70203
to
411aa64
Compare
Closed
5 tasks
Newdea
pushed a commit
to open-spaced-repetition/obsidian-spaced-repetition-recall
that referenced
this pull request
Sep 25, 2024
* fix: parsing code blocks & custom separators
This PR:
1. Adds test cases for parsing {{curly}} clozes
2. Fixes st3v3nmw#1072
- Ignore 'cards' in ```block`` & `inline` codeblocks
- Adds test cases for both
3. Fixes st3v3nmw#1077
- When all the cloze options aren't being used, `cloze_rules` in
`parser.ts` becomes empty which leads to the empty grammar rule `cloze_text`
which prevents the grammar from being generated. This change adds a
tombstone \0 to address this.
- Adds test cases for this
* Fixed inline code in clozes
* - Fixed issue raised at st3v3nmw#1072 (comment) where inline code was not properly hanlded by clozes
- Fixed a new issue related to the case when the user provides empty markers for the inline and multiline cards. With the new version, the rule is disabled when the marker is empty.
* add parser test case
* add more parser test cases
---------
Co-authored-by: Andrea Alberti <a.alberti82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
inlinecodeblockscloze_rulesinparser.tsbecomes empty which leads to the empty grammar rulecloze_textwhich prevents the parser from being generated. This change puts a tombstone\0instead to address this.