Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text inputs for clozes #644

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

goran-zdjelar
Copy link

Fix: issue with only being able to have one cloze per card

Description: before the fix, you could only put one cloze per card as it can bee seen on the gif below

cloze-not-working

Feature: replaced [...] with input fields that are later being evalueted

Description: instead of showing [...] now there are input fields that you can fill and after you press Show Answer it will give you feedback if your input was correct or no. In case it's not correct it will show you the correct answer.

cloze-inputs

Note

I moved creation of Flash Card back to flashcard-modal.tsx as the values of inputs can be evalueted only after they are rendered.

@goran-zdjelar goran-zdjelar requested a review from st3v3nmw as a code owner March 12, 2023 19:03
@AB1908
Copy link
Contributor

AB1908 commented Jun 6, 2023

Wow this is actually pretty cool. I will try and steal this for my fork :)

@fastrick
Copy link

fastrick commented Jul 4, 2023

Awesome idea. I think this feature can be placed as option in the config file, or using a hashtag option in the line.

@mariomui
Copy link

mariomui commented Aug 2, 2023

This is super cool. but seems like it has conflicts.

Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution 😄!

Sorry the underlying code has gone through a major refactor recently. I'm not sure if you're still available to help resolve the merge conflicts.

Stephen,

@ronzulu ronzulu linked an issue Jul 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Input Text Field
5 participants