Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema description doesn't match what the text says for unit/scale/offset #32

Closed
philvarner opened this issue Apr 18, 2022 · 2 comments · Fixed by #41
Closed

schema description doesn't match what the text says for unit/scale/offset #32

philvarner opened this issue Apr 18, 2022 · 2 comments · Fixed by #41
Assignees

Comments

@philvarner
Copy link

The schema says that:

  • unit is "Unit denomination of the pixel value"
  • scale is "multiplicator factor of the pixel value to transform into the value
  • offset is "number to be added to the pixel value to transform into the value"

note the specific use of "pixel value" rather than "the value"

However, the example in the README of how to transform a unitless DN to Radiance seems to specify the unit after the conversion:

"unit": "W⋅sr−1⋅m−3",
"scale": 0.0145,
"offset": 3.48
@emmanuelmathot
Copy link
Member

maybe the "pixel" word is superfluous.
Concerning the scale and offset, those are parameters of a function for the data value to get the proper value in the specified unit. Initially, it was proposed to have an array of objects to specify several values (e.g. radiance, TOA reflectance, BOA, ...)
Maybe a clarification may help in the readme.

@arthurelmes
Copy link

arthurelmes commented Mar 16, 2023

Also, shouldn't the radiance units be watts * sr-1 * m^-2 instead of m^-3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants