Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces from CBERS4 MUX 027 #140

Closed
schwehr opened this issue Aug 14, 2020 · 3 comments · Fixed by #157
Closed

Remove spaces from CBERS4 MUX 027 #140

schwehr opened this issue Aug 14, 2020 · 3 comments · Fixed by #157

Comments

@schwehr
Copy link
Collaborator

schwehr commented Aug 14, 2020

pystac/tests/data-files/catalogs/test-case-5/CBERS4/CBERS4MUX/CBERS4 MUX 027/ has spaces in the directory path. Unless the spaces are an explicit part of the tests, is it okay to remove them? I just got bit by these when using xargs

e.g. trying to get to this file with some tools requires extra care with two directory components containing spaces.

tests/data-files/catalogs/test-case-5/CBERS4/CBERS4MUX/CBERS4 MUX 027/CBERS4 MUX 027/069/CBERS_4_MUX_20190510_027_069_L2/CBERS_4_MUX_20190510_027_069_L2.json
@lossyrob
Copy link
Member

@schwehr thanks for the issue! There shouldn't be anything that depends on the spaces, so this would be a fine change. I think changing the paths and any link HREFs in the STAC would do the trick; is this something you could submit a PR for?

@schwehr
Copy link
Collaborator Author

schwehr commented Aug 14, 2020

Great! I'll try to get a PR done in the next week.

@schwehr
Copy link
Collaborator Author

schwehr commented Aug 18, 2020

Working on it. I see this one failure before I change anything. Documenting so when it fails when I've got a PR, I don't stress over it.

git rev-parse HEAD
c87f073bacc82ae5dfb125f74cb29774678dad11

python -m unittest discover tests
.......................................................................F............................................
======================================================================
FAIL: test_full_copy_4 (test_catalog.FullCopyTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/google/home/schwehr/src/pystac-schwehr/tests/test_catalog.py", line 644, in test_full_copy_4
    self.assertTrue(os.path.exists(href))
AssertionError: False is not true

schwehr added a commit to schwehr/pystac that referenced this issue Aug 18, 2020
Spaces make life more difficult.

Fixes stac-utils#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants