Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RequiredPropertyMissing exception where appropriate #315

Closed
lossyrob opened this issue Apr 28, 2021 · 1 comment · Fixed by #561
Closed

Implement RequiredPropertyMissing exception where appropriate #315

lossyrob opened this issue Apr 28, 2021 · 1 comment · Fixed by #561
Assignees
Milestone

Comments

@lossyrob
Copy link
Member

#309 implements an exception that raises when a required property is missing, using the repr of an object in the message to give users as much detail as possible to identify where the error is. This issue will apply after that PR is merged, and the goal of the issue is to implement throwing this exception (normally via the get_required utility method) where appropriate and ensuring that object reprs give details for any object that is throwing this exception.

@lossyrob lossyrob changed the title Draft issue: Implement RequiredPropertyMissing exception where appropriate Implement RequiredPropertyMissing exception where appropriate May 3, 2021
@cholmes cholmes added this to the 1.0.0 milestone May 24, 2021
@duckontheweb
Copy link
Contributor

@lossyrob My sense is that this would represent a breaking change since many of these cases currently return None, but would raise and exception after applying this change. If that's the case it might be good to get this in under an RC1 release, but if it's not breaking we could probably release without it.

@duckontheweb duckontheweb mentioned this issue Jul 8, 2021
5 tasks
@duckontheweb duckontheweb self-assigned this Jul 16, 2021
duckontheweb pushed a commit that referenced this issue Jul 17, 2021
…erty-exception

Use get_required to raise RequiredPropertyMissing when appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants