Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissively deserialize temporal extents #1222

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Permissively deserialize temporal extents #1222

merged 1 commit into from
Sep 22, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 22, 2023 •
edited
Loading

Related Issue(s):

Description:

Thanks to @giswqs for the report! Since this will enable use of one of the larger open catalogs out there, we'll try to get a PATCH release out after this is merged.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell September 22, 2023 11:12
@gadomski gadomski self-assigned this Sep 22, 2023
@gadomski gadomski force-pushed the issues/1221-permissive-extent-deserialization branch from c95b989 to 2def271 Compare September 22, 2023 11:13
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
pystac/collection.py 100.00%

📢 Thoughts on this report? Let us know!.

@gadomski gadomski mentioned this pull request Sep 22, 2023
Closed
jsignell
jsignell approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gadomski gadomski added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit b63adb4 Sep 22, 2023
@gadomski gadomski deleted the issues/1221-permissive-extent-deserialization branch September 22, 2023 19:09
@gadomski gadomski mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permissively deserialize invalid temporal extents
2 participants
@gadomski @jsignell