Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HREF when opening files #1234

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Allow HREF when opening files #1234

merged 2 commits into from
Sep 27, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 27, 2023 •
edited
Loading

Related Issue(s):

Description:

Functionally this worked, but the typing needed a fix.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell September 27, 2023 15:27
@gadomski gadomski self-assigned this Sep 27, 2023
@gadomski
fix: allow HREF when opening files
269f607 
Functionally this worked, but the typing needed a fix.
jsignell
jsignell approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Might be worth grepping around for from_file(str(

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pystac/catalog.py 93.37% <ø> (ø)
pystac/item_collection.py 94.44% <100.00%> (+0.07%) ⬆️
pystac/stac_object.py 95.13% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@gadomski gadomski enabled auto-merge September 27, 2023 16:11
@gadomski gadomski added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 9c323c4 Sep 27, 2023
@gadomski gadomski deleted the issues/1216-pathlib branch September 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept pathlib.Path when opening files
2 participants
@gadomski @jsignell