Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom StacIO init needs to call parent init #1308

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

tylere
Copy link
Contributor

@tylere tylere commented Feb 7, 2024

Related Issue(s):

none

Description:
This fixes tutorial code that accesses S3, which probably broke with commit 01f71b1.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8004c10) 91.18% compared to head (9c5bc59) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1308   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          51       51           
  Lines        7023     7023           
  Branches     1005     1005           
=======================================
  Hits         6404     6404           
  Misses        444      444           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@gadomski gadomski enabled auto-merge February 8, 2024 13:04
@gadomski gadomski added this pull request to the merge queue Feb 8, 2024
Merged via the queue into stac-utils:main with commit 8079dd3 Feb 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants