Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python unittest's checks to get better error messages on failure. #158

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Use python unittest's checks to get better error messages on failure. #158

merged 1 commit into from
Aug 18, 2020

Conversation

schwehr
Copy link
Collaborator

@schwehr schwehr commented Aug 18, 2020

assertTrue(thing) -> assertEqual, assertIn, assertIsInstance

@schwehr
Use python unittest's checks to get better error messages on failure.
ccc0245 
assertTrue(thing) -> assertEqual, assertIn, assertIsInstance
lossyrob
lossyrob approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great changes, thanks!

@lossyrob lossyrob merged commit 4841bd6 into stac-utils:develop Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossyrob lossyrob lossyrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schwehr @lossyrob