Implement SAR extension. #33

[schwehr]

I'm new to type hints, so they aren't totally perfect. The classmethods are likely incorrect. It would be great to get help to make them be correct or we can drop them. Type hints tested with pytype.

It seems like there should be a subset of sar available for collections. e.g. this, which is definitely not correct.

• https://earthengine-stac.storage.googleapis.com/catalog/COPERNICUS_S1_GRD.json
• https://console.cloud.google.com/storage/browser/_details/earthengine-stac/catalog/COPERNICUS_S1_GRD.json

[lossyrob]

There is a TODO for documentation, but a review request. Is this still in draft state?

[schwehr]

Yes, still a draft. I was hoping you'd take a look at the non-doc part.

But hold off on that and I'll give it another look over myself and add the docs.

Sorry I'm having so much trouble with the github workflow. The tooling feels very different than the reviews I do internally at Google.

[lossyrob]

Gotcha - no worries. I just wasn't sure the state of things. If there's something particular you'd like me to take a look at, happy to, otherwise I think it'll shorten the review cycles if the review can happen all at once when the PR is out of draft phase.

[codecov-io]

Codecov Report

Merging #203 into develop will increase coverage by 0.69%.
The diff coverage is 99.33%.

@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
+ Coverage    92.18%   92.88%   +0.69%     
===========================================
  Files           28       29       +1     
  Lines         3341     3515     +174     
===========================================
+ Hits          3080     3265     +185     
+ Misses         261      250      -11     

Impacted Files	Coverage Δ
pystac/extensions/sar.py	99.33% <99.33%> (ø)
pystac/__init__.py	100.00% <100.00%> (ø)
pystac/extensions/version.py	98.26% <0.00%> (ø)
pystac/serialization/common_properties.py	100.00% <0.00%> (ø)
pystac/utils.py	97.70% <0.00%> (+0.05%)	⬆️
pystac/validation/stac_validator.py	92.30% <0.00%> (+0.09%)	⬆️
pystac/stac_object.py	95.04% <0.00%> (+0.15%)	⬆️
pystac/catalog.py	90.17% <0.00%> (+0.24%)	⬆️
pystac/collection.py	96.90% <0.00%> (+0.44%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf8b42...0017df7. Read the comment docs.

[lossyrob]

Looks great, and good to merge. Few things:

• I added a commit to put the API docs in
• I created Handle setting None consistently in extensions. #230 to track making our usage of optional properties being set as None, and how that affects the apply method.
• I created Refactor to use Enums consistently in PySTAC #231 to track making our usage of Enums consistent. You're using enums here, but they are not used in throughout the rest of the library. I think that's good for now, but we want to eventually be consistent on our usage. If you have opinions about that, please comment in the issue!