Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cloned asset owner during item clone. #228

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Set cloned asset owner during item clone. #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pystac/item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@ def clone(self):
for link in self.links:
clone.add_link(link.clone())

clone.assets = dict([(k, a.clone()) for (k, a) in self.assets.items()])
for k, asset in self.assets.items():
clone.add_asset(k, asset.clone())

return clone

Expand Down
10 changes: 10 additions & 0 deletions tests/test_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ def test_0_9_item_with_no_extensions_does_not_read_collection_data(self):
did_merge = pystac.serialization.common_properties.merge_common_properties(item_json)
self.assertFalse(did_merge)

def test_clone_sets_asset_owner(self):
cat = TestCases.test_case_2()
item = next(cat.get_all_items())
original_asset = list(item.assets.values())[0]
assert original_asset.owner is item

clone = item.clone()
clone_asset = list(clone.assets.values())[0]
self.assertIs(clone_asset.owner, clone)


class CommonMetadataTest(unittest.TestCase):
def setUp(self):
Expand Down