Extract method to correctly handle setting properties in Item/Asset for ItemExtensions #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored extension to use this parent method instead of locally implementing the same logic repeatedly
…et_property # Conflicts: # pystac/extensions/projection.py
Codecov Report
@@ Coverage Diff @@
## develop #272 +/- ##
===========================================
+ Coverage 93.99% 94.05% +0.06%
===========================================
Files 32 32
Lines 4010 3956 -54
===========================================
- Hits 3769 3721 -48
+ Misses 241 235 -6
Continue to review full report at Codecov.
|
lossyrob
added a commit
that referenced
this pull request
Mar 11, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to the ItemExtension class, that makes it easier and more robust for derived classes to set properties in Assest and/or Items.
Existing extensions needing that mechanism have been refactored to rely on the parent method instead
This was discussed in #270
If this PR is merged, #230 will be no longer needed