Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_bands in AssetEOExtension to return None if no eo:bands property for the asset #406

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Fix get_bands in AssetEOExtension to return None if no eo:bands property for the asset #406

merged 5 commits into from
Jun 7, 2021

Conversation

emmanuelmathot
Copy link
Contributor

@emmanuelmathot emmanuelmathot commented Jun 3, 2021 •
edited
Loading

Related Issue(s): #404

Description:

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@emmanuelmathot emmanuelmathot changed the title Fixes #404 Fix get_bands in AssetEOExtension to return None if no eo:bands property for the asset Jun 3, 2021
duckontheweb
duckontheweb approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment related to the CHANGELOG, but LGTM otherwise. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
emmanuelmathot and others added 3 commits June 7, 2021 15:37
@emmanuelmathot @duckontheweb
remove test loop
217a098 
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
@emmanuelmathot
mtd_asset
1c806b3
@duckontheweb
Fix lint error
fcee6cd
@duckontheweb duckontheweb linked an issue Jun 7, 2021 that may be closed by this pull request
[BUG] EO extension get_bands on a non-EO asset returns Item bands #404
Closed
@duckontheweb duckontheweb merged commit b2153c8 into stac-utils:main Jun 7, 2021
@emmanuelmathot emmanuelmathot deleted the fix404 branch June 7, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckontheweb duckontheweb duckontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] EO extension get_bands on a non-EO asset returns Item bands
2 participants
@emmanuelmathot @duckontheweb