Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserve_dict parameter to ItemCollection.from_dict #468

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

lossyrob
Copy link
Member

@lossyrob lossyrob commented Jun 21, 2021

Related Issue(s): #453

Description:

When I made #454, I wasn't hip to the fact the ItemCollection got merged in already. This PR adds the preserve_dict parameter to ItemCollection.from_dict and uses preserve_dict=False when using ItemCollection.from_file.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021

Codecov Report

Merging #468 (2beaccd) into main (d51dd28) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          40       40           
  Lines        5240     5240           
=======================================
  Hits         4794     4794           
  Misses        446      446           
Impacted Files Coverage Δ
pystac/item_collection.py 95.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51dd28...2beaccd. Read the comment docs.

@lossyrob lossyrob requested a review from duckontheweb June 21, 2021 15:36
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding this!

@lossyrob lossyrob merged commit 1826471 into main Jun 22, 2021
@lossyrob lossyrob deleted the fix/rde/preserve-dict-itemcollection branch June 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants