Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify error using add_if_missing on ownerless asset #746

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Clarify error using add_if_missing on ownerless asset #746

merged 3 commits into from
Feb 22, 2022

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Feb 8, 2022 •
edited
Loading

Related Issue(s):

Description:

Clarifies the error message when someone tries to use add_if_missing=True on an Asset with no owner.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob February 8, 2022 14:57
@duckontheweb duckontheweb added this to the 1.4.0 milestone Feb 8, 2022
@duckontheweb duckontheweb merged commit 1a1ff77 into stac-utils:main Feb 22, 2022
@duckontheweb duckontheweb deleted the fix/634-ownerless-asset-exception branch February 22, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossyrob lossyrob lossyrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Clarify error message when trying to add Extension to asset with no owner
2 participants
@duckontheweb @lossyrob