Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/576 AssetDefinition missing create, apply #768

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

guidorice
Copy link
Contributor

@guidorice guidorice commented Mar 18, 2022

Related Issue(s): #

Fixes #576

Description:

  • Adds missing create and apply to Asset Definition
  • Enhances an unrelated unit test, which I noticed while comparing other code (test_eo.py)
  • Fixes old commonmark version in some docstrings.
  • Fixes docstrings referencing RC of stac spec.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #768 (f3ab90d) into main (a19365b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   94.54%   94.55%           
=======================================
  Files          79       79           
  Lines       11626    11647   +21     
  Branches     1372     1372           
=======================================
+ Hits        10992    11013   +21     
  Misses        455      455           
  Partials      179      179           
Impacted Files Coverage Δ
pystac/catalog.py 92.15% <ø> (ø)
pystac/collection.py 94.26% <ø> (ø)
pystac/extensions/item_assets.py 86.00% <100.00%> (+1.55%) ⬆️
tests/extensions/test_eo.py 100.00% <100.00%> (ø)
tests/extensions/test_item_assets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19365b...f3ab90d. Read the comment docs.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @guidorice, and thanks for catching some of the outdated docstrings. Always good to have a new set of eyes on this stuff!

@duckontheweb duckontheweb merged commit c44c79c into stac-utils:main Mar 30, 2022
@guidorice guidorice deleted the fix/576-asset-definition branch March 30, 2022 14:22
@duckontheweb duckontheweb added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add create and apply methods to AssetDefinition
3 participants