Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin FastAPI to avoid OpenAPI docs rendering issues #246

Merged
merged 6 commits into from
Aug 27, 2021
Merged

Pin FastAPI to avoid OpenAPI docs rendering issues #246

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de6868e
Reorder install order in docker build; remove tiles from extension
lossyrob Aug 27, 2021
2554c5c
Pin fastapi in stac_fastapi.types; remove from other packages.
lossyrob Aug 27, 2021
eef06d5
Remove tiler tests.
lossyrob Aug 27, 2021
600ae18
Add changelog entry
lossyrob Aug 27, 2021
54df96c
Install types first in CI, as it's the base subpackage
lossyrob Aug 27, 2021
7933b80
Remove stac_fastapi.extensions[tiles] from test install.
lossyrob Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/cicd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ jobs:
run: |
python -m pip install --upgrade pipenv wheel

- name: Install core api
run: |
pip install ./stac_fastapi/api[dev]

- name: Install types
run: |
pip install ./stac_fastapi/types[dev]

- name: Install core api
run: |
pip install ./stac_fastapi/api[dev]

- name: Install Extensions
run: |
pip install ./stac_fastapi/extensions[dev,tiles]
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Fixed

* Pin FastAPI to 0.67 to avoid issues with rendering OpenAPI documentation ([#246](https://github.com/stac-utils/stac-fastapi/pull/246))

## [2.1.0]

### Added
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ COPY . /app
ENV PATH=$PATH:/install/bin

RUN mkdir -p /install && \
pip install -e ./stac_fastapi/api[dev] && \
pip install -e ./stac_fastapi/types[dev] && \
pip install -e ./stac_fastapi/extensions[dev,tiles] && \
pip install -e ./stac_fastapi/api[dev] && \
pip install -e ./stac_fastapi/extensions[dev] && \
pip install -e ./stac_fastapi/sqlalchemy[dev,server] && \
pip install -e ./stac_fastapi/pgstac[dev,server]
2 changes: 1 addition & 1 deletion stac_fastapi/api/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
desc = f.read()

install_requires = [
"fastapi",
"attrs",
"pydantic[dotenv]",
"stac_pydantic==2.0.*",
"brotli_asgi",
"stac-fastapi.types",
]

extra_reqs = {
Expand Down
1 change: 0 additions & 1 deletion stac_fastapi/extensions/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
desc = f.read()

install_requires = [
"fastapi",
"attrs",
"pydantic[dotenv]",
"stac_pydantic==2.0.*",
Expand Down
1 change: 0 additions & 1 deletion stac_fastapi/pgstac/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
desc = f.read()

install_requires = [
"fastapi",
"attrs",
"orjson",
"pydantic[dotenv]",
Expand Down
1 change: 0 additions & 1 deletion stac_fastapi/sqlalchemy/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
desc = f.read()

install_requires = [
"fastapi",
"attrs",
"pydantic[dotenv]",
"stac_pydantic==2.0.*",
Expand Down
75 changes: 0 additions & 75 deletions stac_fastapi/sqlalchemy/tests/features/test_tiles_extension.py
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion stac_fastapi/types/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
desc = f.read()

install_requires = [
"fastapi",
# We need to pin fastapi for the openapi schema
# See https://github.com/stac-utils/stac-fastapi/issues/242
"fastapi==0.67.*",
"attrs",
"pydantic[dotenv]",
"stac_pydantic==2.0.*",
Expand Down