Return existing links in pgstac #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
requested changes
Nov 1, 2021
Explain why we resolve the href for extra_links in get_links
lossyrob
force-pushed
the
fix/rde/license-link
branch
from
6b847d0
to
e431a3f
Compare
lossyrob
force-pushed
the
fix/rde/license-link
branch
from
e431a3f
to
ae3e1e3
Compare
moradology
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Collections and Items stored in pgstac may have existing links. The example that uncovered this bug is for Collections to link to their licenses with rel=license link. These are currently being overwritten by the hierarchical links derived by stac-fastapi. This change passes through any non-hierarchical links in the pgstac backend.
This also changes the joplin ingest code to use a PUT if the collection or item already exists - useful for changing the development data and re-ingesting.
PR Checklist:
pre-commit run --all-files)make test)make docs)