Only use add method when the value is not ellipsis
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatial-jeff
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Thanks for the PR @nmandery, nice catch! Would you mind adding a test case to prevent regressions in the future? I can help with this if you run into any problems. Thanks 🙏
|
I can create a testcase - sure. I see only testcases in the packages of the individual backends and not for the core, so I simply select one of the two backends - I would chose the sqlalchemy backend - and add the testcase there? |
|
Yes that would be great, thanks! |
nmandery
force-pushed
the
fix-properties-ellipsis-add
branch
from
3b360df
to
3a263ce
Compare
nmandery
force-pushed
the
fix-properties-ellipsis-add
branch
from
3a263ce
to
3c8f33b
Compare
|
Makes definitely sense to have this tested - I just added an testcase. |
|
@nmandery Please update the changelog and we can get this merged 😄 |
…o fix-properties-ellipsis-add # Conflicts: # CHANGES.md
|
Alright - done 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #338
Description:
PR Checklist:
pre-commit run --all-files)make test)make docs)