fix sqlalchemy bulk item insertion #358
Merged
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
requested review from
geospatial-jeff,
vincentsarago and
moradology
kylebarron
reviewed
Feb 27, 2022
| @@ -12,13 +12,13 @@ | |||
|
|
|||
|
|
|||
| class Items(BaseModel): | |||
| """A list of STAC items.""" | |||
| """A group of STAC Item objects, in the form of a dictionary from Item.id -> Item.""" | |||
|
|
|||
| items: Dict[str, Any] | |||
There was a problem hiding this comment.
I haven't followed all the discussion but do we need it as a dict? Or could we just have a list of stac items?
There was a problem hiding this comment.
a list of items would align better with ItemCollection. But I believe the intent of this PR is to fix the current implementation not change how it works.
There was a problem hiding this comment.
Correct, I just wanted to fix the behavior rather than change the expected input
geospatial-jeff
approved these changes
Feb 27, 2022
|
Created an issue here: #362 |
philvarner
force-pushed
the
pv/items-iterator-and-bulk-insert
branch
from
e6a62d5 to
ebc6967
Compare
philvarner
force-pushed
the
pv/items-iterator-and-bulk-insert
branch
from
ebc6967 to
d5f3d64
Compare
|
@geospatial-jeff looks like you'll need to merge, I don't have write perms. |
|
@geospatial-jeff I resolved the merge conflict. I don't have write permission to merge it (which I would gladly accept if you want to grant me it) |
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
SQLAlchemy bulk item insertion failed because the
Itemsiterator returns the keys for the dict it contains, rather than the Item objects themselves as it's docstring says it should (and that it would make sense to).This fixes that problem, and documents what the format of the JSON object that is the input to the bulk insert endpoint is.
PR Checklist:
pre-commit run --all-files)make test)make docs)