Make item geometry and bbox nullable for sqlalchemy backend #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellowcap
force-pushed
the
sqlalchemy-make-item-field-nullable
branch
from
18a9649
to
98c4399
Compare
yellowcap
force-pushed
the
sqlalchemy-make-item-field-nullable
branch
from
98c4399
to
ba3ea09
Compare
|
Ok so the upstream changes are all merged. Since version 2.0.3 of stac-pydantic, the geometry validator includes the nullable option. So the tests pass now and this change is ready for merging from my point of view. @lossyrob would you mind having a look? Thanks! |
lossyrob
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Geometry and bbox fields of the Item table need to be nullable to be compliant with the stac standard. This PR makes the two fields nullable for the sqlalchemy backend.
Most upstream fixes in the pydantic classes have already been merged. One bug fix here stac-utils/stac-pydantic#114 is still in review.
The stac-pydantic library needs to have a new release before this PR can be merged, as the updates in the pydantic validator classes need to be installed so they accept null values for these two fields.
The new test of this PR will pass with the next release of stac-pydantic.
PR Checklist:
pre-commit run --all-files)make test)make docs)