-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use collection_id path parameter Items Transactions endpoints #425
Conversation
I think I'm fairly close to fixing the |
160f831
to
f4b9b89
Compare
This has been fixed and this is ready for review. |
8529d07
to
ba29553
Compare
From the transactions spec (https://github.com/radiantearth/stac-api-spec/blob/master/ogcapi-features/extensions/transaction/README.md):
|
This is the current behavior for this PR, except it returns a 409 status code if the |
ba29553
to
94c2259
Compare
@geospatial-jeff I fixed the response code, so this is ready for final review and/or merge. @philvarner Let me know if you have any feedback on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Add collection_id path parameter and check against Item collection property * Fix unformatted f-strings * Fix Item PUT endpoint per #385 * Update API tests to use new PUT paths * Make equivalent changes to sqlalchemy backend * Add CHANGELOG entry for #425 * Fix failing tests from previous merge * Return 400 for Item id or collection conflicts * Add failing tests * Return added Item/Collection from Transactions endpoints * Format changes * Add CHANGES entry for #424 * Get Transactions Item response collection id from path parameter * remove duplicate test cases Co-authored-by: Jeff Albrecht <geospatialjeff@gmail.com>
Related Issue(s):
Description:
collection_id
path parameter and verify that this collection ID matches the Item's"collection"
property (Transaction Extension: purpose of the collection_id path parameter #406, Transaction Ext: POST and PUT should validate the Item's id and collection match the path's id and collection #384). This also fixes Invalid OpenAPI JSON - path parameter collection_id missing in PUT and POST #416.item_id
path parameter and verify that this Item ID matches the Item's"id"
property (Transactions Extension: PUT endpoint is incorrect, should be /collections/{c_id}/items/{i_id} #385).PR Checklist:
pre-commit run --all-files
)make test
)make docs
)