Add nginx service as second docker-compose stack #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-wygoda
reviewed
Nov 28, 2022
vincentsarago
approved these changes
Nov 28, 2022
gadomski
changed the title
Co-authored-by: Christian Wygoda <103508637+c-wygoda@users.noreply.github.com>
Includes a Makefile rule to run it, and some documentation in README.md. Also adds a markdownlint silencer and one or two touchups to the whitespace.
moradology
force-pushed
the
add-nginx-container
branch
from
7d10a47
to
72cab05
Compare
moradology
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Adds a NGINX container to the docker-compose stack to help debug issues with root paths and link resolution when running the application behind a proxy; and to serve as a minimal reference example for how proxies should be configured. The NGINX server runs on port
80and proxies both backends behind the/api/v1/pgstacand/api/v1/sqlalchemyendpoints, root paths are set accordingly in each application. I added theUVICORN_ROOT_PATHenvironment variable to expose uvicorn's root path argument without rewriting docker commands.PR Checklist:
pre-commit run --all-files)make test)make docs)