use Collection Pydantic model in PutCollection transaction #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 26, 2024
jonhealy1
approved these changes
Apr 29, 2024
vincentsarago
commented
May 3, 2024
| @@ -34,7 +33,7 @@ class PutItem(ItemUri): | |||
| class PutCollection(CollectionUri): | |||
| """Update Collection.""" | |||
|
|
|||
| collection: stac.Collection = attr.ib(default=Body(None)) | |||
| collection: Collection = attr.ib(default=Body(None)) | |||
There was a problem hiding this comment.
@jonhealy1 I'm not sure why but when we use this class (attr) we don't get the validation/serialization 😬
from stac_fastapi.extensions.core.transaction import PutCollection
>>> PutCollection(collection_id='yo', collection={})
PutCollection(collection_id='yo', collection={})
>>> print(type(PutCollection(collection_id='yo', collection={}).collection))
<class 'dict'>you may have seen this also in the elastic search backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was not in #625
Note: we should add a note in the changelog that transaction endpoint now have Pydantic Model instead of TypedDict as input (stac-utils/stac-fastapi-pgstac#108 (comment))