Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add POST - /collections collection-search #739

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

vincentsarago
Copy link
Member

in addition to the collection-search extension work done in #736, this PR adds a POST - /collections endpoint in another extension CollectionSearchPostExtension

@m-mohr
Copy link
Contributor

m-mohr commented Jul 24, 2024

How does this work in combination with Collection Transactions?

@vincentsarago
Copy link
Member Author

vincentsarago commented Jul 24, 2024

@m-mohr it shouldn't be used together, which is why I've created 2 different extension (with and without the POST endpoint)

It will be really weird to have a POST - /collections being able to handle both the transaction and the search IMO.

Maybe we can investigate how to do it in another iteration but for now I believe it's fine having both extensions adding their own POST - /collections endpoint.

In term of code, it will be really complex (nor impossible) to make them work together because they are both extensions so we can't make them depends on each others

@m-mohr
Copy link
Contributor

m-mohr commented Jul 24, 2024

Ah, I didn't realize that. Thanks for the clarification, sounds good to me.

@vincentsarago vincentsarago merged commit 4adcf0e into main Jul 25, 2024
7 checks passed
@vincentsarago vincentsarago deleted the feature/add-post-collection-search branch July 25, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants