ci: add object-store-cache crate to ci

stac-utils · Dec 21, 2024 · fe6a4a5 · fe6a4a5
1 parent a0a4a87
commit fe6a4a5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -99,6 +99,14 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Test
         run: cargo test -p stac-extensions
+  test-object-store-cache:
+    name: Test stac-object-store-cache
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: Swatinem/rust-cache@v2
+      - name: Test
+        run: cargo test -p stac-object-store-cache --all-features
   test-pgstac:
     name: Test pgstac
     runs-on: ubuntu-latest

diff --git a/crates/object-store-cache/src/cache.rs b/crates/object-store-cache/src/cache.rs
@@ -183,8 +183,6 @@ mod tests {
 
         assert!(Arc::ptr_eq(&store, &store2));
         assert!(std::ptr::addr_eq(Arc::as_ptr(&store), Arc::as_ptr(&store2)));
-        // assert_eq!(store.as_ref(), store2.as_ref());
-        // assert_eq!(Arc::as_ptr(&store), Arc::as_ptr(&store2));
         assert_eq!(path.as_ref(), "some/path");
     }
 

diff --git a/crates/object-store-cache/src/error.rs b/crates/object-store-cache/src/error.rs
@@ -5,7 +5,6 @@ use thiserror::Error;
 #[derive(Error, Debug)]
 #[non_exhaustive]
 pub enum Error {
-    /// TODO: Better error description
     #[error("Failed to create object_store for {scheme:?}. Check if required feature is enabled.")]
     ObjectStoreCreate {
         /// feature