Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - Authorization Extra Params in OAuth Base Provider #343

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

earthodev
Copy link

Title:

Fix Authorization Extra Params in OAuth Base Provider

Description:

This PR addresses an issue in the OAuthBaseProvider where the authorizationExtraParams were not correctly passed to the authorization exchange request. This addition ensures that any additional parameters specified in authorizationExtraParams are included, enhancing flexibility for OAuth providers that require custom parameters.

Key Change:

  • Added exchangeBody: this.authorizationExtraParams to the OAuth request body, enabling support for extra authorization parameters.

Impact:

  • Improves compatibility with providers that require specific authorization parameters, enhancing the flexibility and adaptability of the OAuthBaseProvider.

This fix allows better handling of provider-specific requirements without additional configuration. Thank you for reviewing!

Copy link

vercel bot commented Nov 14, 2024

@dvir-daniel is attempting to deploy a commit to the Stack Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants