Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinocchio to foxy and eloquent #1

Closed
wants to merge 1 commit into from

Conversation

Rascof
Copy link

@Rascof Rascof commented Aug 26, 2020

Hello,

I am actually on an internship at LAAS-CNRS / AIP-Primeca to release packages of the Stack of Stacks on melodic, noetic, foxy and eloquent: http://stack-of-tasks.github.io/development.html
I already released dynamic-graph and dynamic-graph-python: https://index.ros.org/p/dynamic-graph/github-stack-of-tasks-dynamic-graph/
Some packages are dependent on Pinocchio to be released on foxy and eloquent. Is it possible to release Pinocchio on those two rosdistros?

Best regards,

Thomas PEYRUCAIN

Add support for foxy and eloquent
@wxmerkt
Copy link
Member

wxmerkt commented Aug 26, 2020

Hi Thomas,
Very happy to hear from you. I am working on updated releases for EigenPy and Pinocchio on the current ROS1 releases (kinetic, melodic, noetic). There might be some fixes for the buildfarms required to get those going. I can keep you posted but it will take some time.

I can't merge this PR as is as it does not come with the tags. I can run bloom for ROS2 as well to get the releases going. It does require patching though so might take a few attempts. Did you run a pre-release test for eloquent and foxy?

Best regards,
Wolfgang

@Rascof
Copy link
Author

Rascof commented Aug 26, 2020

Ok no problem I can continue with the other packages on melodic and noetic when waiting for Pinocchio to be released on ROS2

The pre-release process is only available on kinetic, melodic and noetic on the website: http://prerelease.ros.org/
I don't know other option to do the pre-release on ROS2.
I had no issues to release dynamic-graph on foxy and eloquent with the exec_depend on ament_cmake for ROS2.

Best regards,
Thomas PEYRUCAIN

@wxmerkt
Copy link
Member

wxmerkt commented Aug 26, 2020

Upon reflection, I want to wait with the Pinocchio releases until stack-of-tasks/pinocchio#1284 has landed and a new release is created. This is an important and useful update. I'll release EigenPy 2.5.0 in the meantime as a preparation.

@wxmerkt
Copy link
Member

wxmerkt commented Aug 26, 2020

Update - the EigenPy releases are out. If they get merged and come back green, I can continue on the Pinocchio ones. Eloquent required patches for finding NumPy. Both required patches for Debian Buster and fixing the install paths from jrl-cmake-modules.

EigenPy

@wxmerkt
Copy link
Member

wxmerkt commented Aug 31, 2020

Pinocchio

Please note that due to memory exhaustion on the buildfarm when building the Python bindings it may take several days / a week to get all builds to go through once these are merged...

@wxmerkt wxmerkt closed this Aug 31, 2020
@Rascof
Copy link
Author

Rascof commented Aug 31, 2020

Nice thank you very much ^^

@wxmerkt
Copy link
Member

wxmerkt commented Sep 2, 2020

The foxy and eloquent releases are due to be reverted due to memory exhaustion cf. ros-infrastructure/buildfarm_deployment#232

Could you look into whether there are ways to reduce memory requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants