Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service exposition docs #320

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Service exposition docs #320

merged 7 commits into from
Aug 31, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Aug 31, 2023

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@fhennig fhennig mentioned this pull request Aug 31, 2023
Closed
1 task
maltesander
maltesander reviewed Aug 31, 2023
View reviewed changes
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
maltesander
maltesander previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig fhennig enabled auto-merge August 31, 2023 12:19
maltesander
maltesander previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maltesander
maltesander approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig fhennig added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 0f6feff Aug 31, 2023
30 checks passed
@fhennig fhennig deleted the docs/listenerclass branch August 31, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @maltesander