Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap entrypoint script to trigger pre/post hook commands #435

Merged
merged 2 commits into from
Aug 17, 2023
Merged

wrap entrypoint script to trigger pre/post hook commands #435

merged 2 commits into from
Aug 17, 2023

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Aug 17, 2023 •
edited
Loading

Description

As per spark-k8s, the entrypoint script is wrapped in a runner script that evaluates/triggers the vector shutdown command via an environment variable (if set).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks
Beta Give feedback

@adwk67 adwk67 mentioned this pull request Aug 17, 2023
Merged
@adwk67 adwk67 linked an issue Aug 17, 2023 that may be closed by this pull request
Extend Airflow operator by implementing KubernetesExecutor stackabletech/airflow-operator#2
Closed
maltesander
maltesander approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit e7f6fe2 Aug 17, 2023
14 checks passed
@adwk67 adwk67 deleted the airflow-post-hook branch August 17, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Airflow operator by implementing KubernetesExecutor
2 participants
@adwk67 @maltesander