Remove sed calls to replace KERBEROS_REALM as they are not needed any more when HBase is built against Hadoop 3 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the syntax differs between what hdfs expects and what config-utils uses, this only works together with the sister PR in hdfs-operator from branch `fix/config-util-compatible-discovery`.
Since we build HBase with Hadoop 3 these days, the functionality to use environment variables in config files is now available natively and we do not need to rely on sed anymore.
soenkeliebau
changed the title
This reverts commit cbfaabd.
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
This reverts commit 1053d73.
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
This reverts commit 0f8bc03.
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
This reverts commit 4bb9563.
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
lfrancke
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the past we built HBase against Hadoop 2.x, in which the Configuration object did not yet support the syntax for using environment variables in config files:
${env.VARNAME}To work around this we added sed calls to do the replacement in the config files during container startup.
Since we now build HBase with Hadoop 3.x this functionality is now supported by HBase and we don't need these calls to sed anymore, as the placeholders will be replaced by HBase at runtime.
This PR removes the now unneeded calls.
Definition of Done Checklist
Author
Reviewer
Acceptance