fix: env-overrides with tests #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
adwk67
changed the title
razvan
previously approved these changes
Aug 19, 2024
rust/crd/src/lib.rs
Outdated
| @@ -655,4 +671,134 @@ impl HbaseCluster { | |||
| tracing::debug!("Merged config: {:?}", conf_rolegroup); | |||
| fragment::validate(conf_rolegroup).context(FragmentValidationFailureSnafu) | |||
| } | |||
|
|
|||
| pub fn merged_env(&self, rolegroup_config: Option<&BTreeMap<String, String>>) -> Vec<EnvVar> { | |||
There was a problem hiding this comment.
What do you think about renaming it and making it a stand alone function ? For example:
pub fn make_env (env_map: Option<&BTreeMap<String, String>>) -> Vec<EnvVar>
There was a problem hiding this comment.
Good idea! Changed here: 0545c9c
There was a problem hiding this comment.
I would have also renamed it to make_env or something else more general since it knows nothing about merged configuration.
|
why is the "definition of done" duplicated ? :) |
razvan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: implemented env-var merge and added tests
Tests:
AKS: 🟢
OKD: 🟢 (except Omid test, but a separate issue has been opened for that)
Definition of Done Checklist
Author
Reviewer
Acceptance