[Merged by Bors] - Rework s3 configuration #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
reviewed
May 11, 2022
sbernauer
approved these changes
May 12, 2022
Yeah i wanna try to create something today, or at least integrate that in the trino one. |
sbernauer
approved these changes
May 13, 2022
sbernauer
approved these changes
May 17, 2022
sbernauer
force-pushed
the
rework_s3_configuration
branch
from
99a5ce0 to
a786b5b
Compare
…work_s3_configuration # Conflicts: # Cargo.lock # rust/crd/Cargo.toml # rust/operator-binary/Cargo.toml
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 17, 2022
## Description closes #138 integration test: https://github.com/stackabletech/integration-tests/pull/239 Currently requires a certain secret operator pr: `helm install secret-operator stackable-test/secret-operator --version=0.3.0-pr125` ### TODO - [x] Use operator-rs tag 0.21.0 Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #138
integration test: https://github.com/stackabletech/integration-tests/pull/239
Currently requires a certain secret operator pr:
helm install secret-operator stackable-test/secret-operator --version=0.3.0-pr125TODO
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information