Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Updating Tests to new Hive version #211

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Updating Tests to new Hive version #211

wants to merge 4 commits into from

Conversation

Maleware
Copy link
Contributor

Description

Please add a description here. This will become the commit message of the merge request later.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer
Copy link
Member

LGTM. Ci test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/4/console

@sbernauer
Copy link
Member

Can you please add an CHANGELOG.md entry like "Add support for Hive 3.1.3"?

@Maleware
Copy link
Contributor Author

Can you please add an CHANGELOG.md entry like "Add support for Hive 3.1.3"?

Done

sbernauer
sbernauer approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests passed

@Maleware
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 18, 2022
@Maleware @sbernauer
Updating Tests to new Hive version (#211)
94b165e 
# Description

*Please add a description here. This will become the commit message of the merge request later.*



Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@bors
Copy link
Contributor

bors bot commented Jul 18, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Updating Tests to new Hive version [Merged by Bors] - Updating Tests to new Hive version Jul 18, 2022
@bors bors bot closed this Jul 18, 2022
@bors bors bot deleted the test-update branch July 18, 2022 14:30
@sbernauer sbernauer mentioned this pull request Jul 19, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maleware @sbernauer