Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add missing role to read S3Connection objects #220

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add missing role to read S3Connection objects #220

wants to merge 1 commit into from

Conversation

sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from a team August 5, 2022 12:45
maltesander
maltesander approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Aug 5, 2022
@sbernauer
Add missing role to read S3Connection objects (#220)
e77832f 
# Description

*Please add a description here. This will become the commit message of the merge request later.*
@bors
Copy link
Contributor

bors bot commented Aug 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add missing role to read S3Connection objects [Merged by Bors] - Add missing role to read S3Connection objects Aug 5, 2022
@bors bors bot closed this Aug 5, 2022
@bors bors bot deleted the fix-roles-s3 branch August 5, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander