Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement resource requests and limits for Hive pods #242

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - Implement resource requests and limits for Hive pods #242

wants to merge 11 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 13, 2022 •
edited by adwk67
Loading

Description

  • PVC, memory and CPU requests and limits now configurable
  • added new integration tests folder "resources"

closes #217

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team September 13, 2022 10:49
@maltesander maltesander self-assigned this Sep 13, 2022
@maltesander maltesander marked this pull request as ready for review September 13, 2022 10:52
@maltesander
Copy link
Member Author

Test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/8/

@adwk67 adwk67 requested review from adwk67 and removed request for a team September 14, 2022 12:59
adwk67
adwk67 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 15, 2022
@maltesander
Implement resource requests and limits for Hive pods (#242)
9592a30 
# Description

- PVC, memory and CPU requests and limits now configurable
- added new integration tests folder "resources"

closes #217



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement resource requests and limits for Hive pods [Merged by Bors] - Implement resource requests and limits for Hive pods Sep 15, 2022
@bors bors bot closed this Sep 15, 2022
@bors bors bot deleted the resource_limits branch September 15, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement resource requests and limits for Hive pods
2 participants
@maltesander @adwk67