Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Consolidated CRD to top level cluster config #292

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - Consolidated CRD to top level cluster config #292

wants to merge 12 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jan 10, 2023 •
edited by sbernauer
Loading

Description

This is a consolidation PR as prerequisite for logging.

fixes #291

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from sbernauer January 10, 2023 14:56
@maltesander maltesander self-assigned this Jan 10, 2023
@maltesander maltesander marked this pull request as ready for review January 10, 2023 15:04
sbernauer
sbernauer requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nit-picking.

Do you mind creating follow-up PRs for the depended products? I can only think of Trino (maybe Spark has a HMS test as well)

rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
@maltesander maltesander requested a review from sbernauer January 10, 2023 15:24
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@maltesander
Consolidated CRD to top level cluster config (#292)
4828fd1 
# Description

This is a consolidation PR as prerequisite for logging.

fixes #291



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Canceled.

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@maltesander
Consolidated CRD to top level cluster config (#292)
b3812c3 
# Description

This is a consolidation PR as prerequisite for logging.

fixes #291



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Consolidated CRD to top level cluster config [Merged by Bors] - Consolidated CRD to top level cluster config Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the logging-preparation branch January 10, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate database, s3, hdfs into top-level cluster config
2 participants
@maltesander @sbernauer