[Merged by Bors] - Enable logging #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # deploy/manifests/crds.yaml
siegfriedweber
requested changes
Jan 27, 2023
tests/templates/kuttl/logging/00-install-vector-aggregator-discovery-configmap.yaml.j2
Show resolved
Hide resolved
tests/templates/kuttl/logging/01-install-hbase-vector-aggregator.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
siegfriedweber
requested changes
Jan 27, 2023
tests/templates/kuttl/resources/00-install-vector-aggregator-discovery-configmap.yaml.j2
Show resolved
Hide resolved
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
# Description
- Added log4j2 logging for Hive
If logging is set to DEBUG, there will be some exceptions due to null values in the XML string from `DataNucleus`.
```
ERROR StatusLogger com.fasterxml.jackson.core.JsonGenerationException: Invalid null character in text to output
com.fasterxml.jackson.core.JsonGenerationException: Invalid null character in text to output
at com.fasterxml.jackson.dataformat.xml.util.StaxUtil.throwAsGenerationException(StaxUtil.java:51)
```
Printed null values causing the problem (without XML format):
```
bash-4.4$ sed -n '/\x0/ { s/\x0/<NUL>/g; p}' /stackable/log/test.log
[DEBUG] 2023-01-20 13:33:24.637 [main] Transaction - Transaction created [DataNucleus Transaction, ID=Xid=<NUL><NUL><NUL>, enlisted resources=[]]
[DEBUG] 2023-01-20 13:33:24.647 [main] Transaction - Running enlist operation on resource: org.datanucleus.store.rdbms.ConnectionFactoryImpl$EmulatedXAResource@687e4c93, error code TMNOFLAGS and transaction: [DataNucleus Transaction, ID=Xid=<NUL><NUL><NUL>, enlisted resources=[]]
[DEBUG] 2023-01-20 13:33:24.647 [main] Connection - ManagedConnection(enlisted) "org.datanucleus.store.rdbms.ConnectionFactoryImpl$ManagedConnectionImpl@3b1ed14b [conn=com.zaxxer.hikari.pool.HikariProxyConnection@3727f0ee, commitOnRelease=false, closeOnRelease=false, closeOnTxnEnd=true]" starting for transaction "Xid=<NUL><NUL><NUL>" with flags "0"
[DEBUG] 2023-01-20 13:33:24.698 [main] Transaction - Committing [DataNucleus Transaction, ID=Xid=<NUL><NUL><NUL>, enlisted resources=[org.datanucleus.store.rdbms.ConnectionFactoryImpl$EmulatedXAResource@687e4c93]]
[DEBUG] 2023-01-20 13:33:24.698 [main] Connection - ManagedConnection(enlisted)
```
## TODO
- [x] Adapt image version in examples, docs, tests
- [x] Adapt changelog
fixes: #290
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If logging is set to DEBUG, there will be some exceptions due to null values in the XML string from
DataNucleus.Printed null values causing the problem (without XML format):
TODO
fixes: #290
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information