Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: Update vector container resources #347

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - fix: Update vector container resources #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c96f5
fix: Update vector container resources
sbernauer Jun 22, 2023
8f3219c
changelog
sbernauer Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ All notable changes to this project will be documented in this file.

- Generate OLM bundle for Release 23.4.0 ([#338]).
- Missing CRD defaults for `status.conditions` field ([#340]).
- Set explicit resources on all container ([#345])
- Set explicit resources on all container ([#345], [#347])

### Changed

Expand All @@ -21,6 +21,7 @@ All notable changes to this project will be documented in this file.
[#338]: https://github.com/stackabletech/hive-operator/pull/338
[#340]: https://github.com/stackabletech/hive-operator/pull/340
[#345]: https://github.com/stackabletech/hive-operator/pull/345
[#347]: https://github.com/stackabletech/hive-operator/pull/347

## [23.4.0] - 2023-04-17

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/hive/pages/usage.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ include::home:concepts:stackable_resource_requests.adoc[]

A minimal HA setup consisting of 2 Hive metastore instances has the following https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/[resource requirements]:

* `700m` CPU request
* `2400m` CPU limit
* `1152m` memory request and limit
* `100m` CPU request
* `3000m` CPU limit
* `1280m` memory request and limit

Of course, additional services, require additional resources. For Stackable components, see the corresponding documentation on further resource requirements.

Expand Down
14 changes: 6 additions & 8 deletions rust/operator-binary/src/controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,19 +843,17 @@ fn build_metastore_rolegroup_statefulset(
}

if merged_config.logging.enable_vector_agent {
let resources = ResourceRequirementsBuilder::new()
.with_cpu_request("250m")
.with_cpu_limit("1")
.with_memory_request("128Mi")
.with_memory_limit("128Mi")
.build();

pod_builder.add_container(product_logging::framework::vector_container(
resolved_product_image,
STACKABLE_CONFIG_DIR_NAME,
STACKABLE_LOG_DIR_NAME,
merged_config.logging.containers.get(&Container::Vector),
resources,
ResourceRequirementsBuilder::new()
.with_cpu_request("250m")
.with_cpu_limit("500m")
.with_memory_request("128Mi")
.with_memory_limit("128Mi")
.build(),
));
}

Expand Down