Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Support podOverrides #352

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: Support podOverrides #352

wants to merge 7 commits into from

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jul 4, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#346

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@Techassi Techassi self-assigned this Jul 4, 2023
@Techassi Techassi mentioned this pull request Jul 4, 2023
Closed
@Techassi Techassi marked this pull request as ready for review July 4, 2023 14:30
sbernauer
sbernauer reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass % cosmetics

rust/crd/src/affinity.rs Outdated Show resolved Hide resolved
rust/crd/src/affinity.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer self-assigned this Jul 5, 2023
@Techassi Techassi requested a review from sbernauer July 5, 2023 09:52
sbernauer
sbernauer approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@sbernauer
Copy link
Member

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/36/

@sbernauer
Copy link
Member

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/37/

@Techassi
Copy link
Member Author

Techassi commented Jul 5, 2023

Tests passed, see custom operator test #37:

--- PASS: kuttl (2438.00s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/orphaned-resources_hive-latest-3.1.3-stackable0.0.0-dev (507.70s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-3.1.3-stackable0.0.0-dev_openshift-false_s3-use-tls-false (177.14s)
        --- PASS: kuttl/harness/cluster-operation_hive-latest-3.1.3-stackable0.0.0-dev (138.49s)
        --- PASS: kuttl/harness/resources_hive-3.1.3-stackable0.0.0-dev (352.46s)
        --- PASS: kuttl/harness/resources_hive-2.3.9-stackable0.0.0-dev (542.97s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-3.1.3-stackable0.0.0-dev_openshift-false_s3-use-tls-true (197.99s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-2.3.9-stackable0.0.0-dev_openshift-false_s3-use-tls-false (180.78s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-2.3.9-stackable0.0.0-dev_openshift-false_s3-use-tls-true (145.99s)
        --- PASS: kuttl/harness/logging_postgres-12.5.6_hive-3.1.3-stackable0.0.0-dev_openshift-false (96.51s)
        --- PASS: kuttl/harness/logging_postgres-12.5.6_hive-2.3.9-stackable0.0.0-dev_openshift-false (97.44s)

@Techassi
Copy link
Member Author

Techassi commented Jul 5, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 5, 2023
@Techassi @sbernauer
feat: Support podOverrides (#352)
1afd8ee 
# Description

Part of stackabletech/issues#346

## Definition of Done Checklist

- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
- Please make sure all these things are done and tick the boxes
 
```[tasklist]
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
```

```[tasklist]
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
```

```[tasklist]
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
```

Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)


Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@bors
Copy link
Contributor

bors bot commented Jul 5, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Support podOverrides [Merged by Bors] - feat: Support podOverrides Jul 5, 2023
@bors bors bot closed this Jul 5, 2023
@bors bors bot deleted the feat/pod-overrides branch July 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@Techassi Techassi

@sbernauer sbernauer

Labels
release/23.7.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @sbernauer