Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service in discovery configmap #382

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 20, 2023

Description

  • Use metastore service instead of single pod references in discovery config map to enable HA

fixes #380

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@maltesander maltesander requested a review from a team October 20, 2023 12:46
@maltesander maltesander self-assigned this Oct 20, 2023
@adwk67 adwk67 requested review from adwk67 and removed request for a team October 31, 2023 08:23
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typos. Docs are consistent and draw distinction between derby/postgres usage re. replicas. However, although multiple replicas are now reachable internally via a service, the nodeport configmap points to each pod individually which means an external service will still have to some manual work itself to provide HA.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/modules/hive/pages/discovery.adoc Outdated Show resolved Hide resolved
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having discussed this today - LGTM! Maybe we need a specific test for this, but I'll leave that up to you.

@maltesander maltesander added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 8abc303 Nov 3, 2023
29 checks passed
@maltesander maltesander deleted the use-service-in-discovery-configmap branch November 3, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High availability for Hive Metastore
3 participants