Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User authentication with kerberos #402

Merged
merged 52 commits into from
Jan 24, 2024
Merged

User authentication with kerberos #402

merged 52 commits into from
Jan 24, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jan 11, 2024 •
edited by lfrancke
Loading

Description

Closes #387.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

adwk67 and others added 3 commits January 18, 2024 11:57
@adwk67
regenerate charts
32577ad
@adwk67
changelog
3c1a68f
@adwk67 @github-actions
Update tests/templates/kuttl/kerberos/test_script.sh
6b76436 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@adwk67
Copy link
Member Author

adwk67 commented Jan 22, 2024 •
edited
Loading

🟢 Jenkins: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/50/

sbernauer
sbernauer requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, mostly TLS removal stuff

rust/operator-binary/src/kerberos.rs Outdated Show resolved Hide resolved
docs/modules/hive/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
docs/modules/hive/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
docs/modules/hive/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
rust/crd/src/security.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Outdated Show resolved Hide resolved
tests/templates/kuttl/kerberos-hdfs/70-install-access-hive.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/kerberos-s3/70-install-access-hive.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/kerberos-hdfs/70-install-access-hive.yaml.j2 Show resolved Hide resolved
tests/templates/kuttl/kerberos-s3/70-install-access-hive.yaml.j2 Show resolved Hide resolved
adwk67 and others added 4 commits January 23, 2024 12:17
@adwk67 @sbernauer
Update rust/operator-binary/src/kerberos.rs
65d420d 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 @sbernauer
Update docs/modules/hive/pages/usage-guide/security.adoc
05a1e88 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 @sbernauer
Update docs/modules/hive/pages/usage-guide/security.adoc
3d7022e 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 @sbernauer
Update rust/crd/src/security.rs
cf08e57 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
github-actions[bot]
github-actions bot reviewed Jan 23, 2024
View reviewed changes
rust/crd/src/security.rs Outdated Show resolved Hide resolved
rust/crd/src/security.rs Outdated Show resolved Hide resolved
@adwk67
Copy link
Member Author

adwk67 commented Jan 23, 2024

🟢 local tests

@adwk67 adwk67 requested a review from sbernauer January 23, 2024 13:49
sbernauer
sbernauer requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also two other conversations remaining ;)

docs/modules/hive/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
adwk67 and others added 2 commits January 24, 2024 10:46
@adwk67 @sbernauer
Update docs/modules/hive/pages/usage-guide/security.adoc
7968790 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67
removed unused hive/tls code
4b96a23
@adwk67
Copy link
Member Author

adwk67 commented Jan 24, 2024

There are also two other conversations remaining ;)

sorry, missed those. Have hopefully answered them all now.

@adwk67
Copy link
Member Author

adwk67 commented Jan 24, 2024

🟢 local tests ran OK again

sbernauer
sbernauer approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adwk67 adwk67 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit caed204 Jan 24, 2024
30 checks passed
@adwk67 adwk67 deleted the feat/kerberos branch January 24, 2024 12:40
@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/2024-03 labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
release/2024-03 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kerberos authentication for Hive metastore
3 participants
@adwk67 @sbernauer @lfrancke