-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: detail how to mount and use external drivers #449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things, LGTM otherwise.
docs/modules/hive/pages/usage-guide/database-driver-example.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hive/pages/usage-guide/database-driver-example.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hive/pages/usage-guide/database-driver-example.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hive/pages/usage-guide/database-driver-example.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Malte Sander <contact@maltesander.com>
@maltesander I have a local integration test for this. What do you think - shall I push that too and just leave it commented out of the test definitions (so it can be activated as necessary)? I wouldn't leave it active as we would either have to upload the mysql driver to Nexus or have an external dependency. |
I wanna look at it more in depth, but already I'd like the fileame to just be database-driver.adoc and also if you could put linebreaks between sentences (so each sentence is on its own line) that would be great! |
I dont think its in scope here, but having an integration test (could be an existing one) switching to mysql for testing would be nice :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things, thanks for documenting this!
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this!
Would you be willing to also document a small Dockerfile that does something like
FROM <our image>
curl -o /stackable/external-drivers/mysql-connector-j-8.0.31.jar" https://repo1.maven.org/maven2/com/mysql/mysql-connector-j/8.0.31/mysql-connector-j-8.0.31.jar
This should be very easy and help a lot for a lot of customers (that don't have or want ReadWriteMany). IMHO we should also recommend this and only have the PVC part as a last resort but that's just my 2 cents 🙈
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
I think it's a good idea to document the alterantives as well, but it wasn't part of the original scope ofthe ticket. But ideally we'd lay out the options for the users, and then they can decide (Do I want to host an image somewhere? Can I use ReadWriteMany? etc) |
I also volunteer to quickly throw the Dockerfile together, I don't want to put the burden on @adwk67. Shall I do that? |
I've documented it here 64754ea but couldn't get it to work yet. Maybe we can take a look together @sbernauer ? |
ok, got it working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just able to had a look at this and you pushed the solution.
Many thanks for adding the Dockerfile! It builds on my machine and I assume you tested if the image works against mysql.
Requested changes have been implemented.
Description
docs: detail how to mount and use external drivers.
fixes #416.
Definition of Done Checklist
Author
Reviewer
Acceptance